View Ticket

Not logged in
Ticket Hash: 64a89acddb61e3c7f74692a46ba41dfd3f35d104
Title: Remove sqlite3BtreeGetJournalname() from src/vdbeaux.c
Status: Open Type: Code_Defect
Severity: Critical Priority:
Subsystem: Resolution:
Last Modified: 2020-11-09 07:52:33
Version Found In:
User Comments:
danshearer added on 2020-11-09 07:52:33:

sqlite3BtreeGetJournalname() is a journal-mode-specific BTree-specifc function only called once, in vdbeaux.c .

The purpose of this seems to be to abort if the pager says journal/WAL filenames aren't relevant. However we need to intercept this higher up, to allow for alternative backends altogether.

So we should change this function call in vdbeaux.c to be sqlite3BtreeAbortCommit(), which will call sqlite3BtreeGetJournalname() in the case that standard btree is in use.