| Ticket Hash: | 64a89acddb61e3c7f74692a46ba41dfd3f35d104 | ||
| Title: | Remove sqlite3BtreeGetJournalname() from src/vdbeaux.c | ||
| Status: | Closed | Type: | Code_Defect |
| Severity: | Critical | Priority: | Immediate |
| Subsystem: | Resolution: | Fixed | |
| Last Modified: |
2026-06-20 10:47:54 153.3 days ago |
Created: |
2020-11-09 07:52:33 6.03 years ago |
| Version Found In: | |||
| User Comments: | ||||
danshearer added on 2020-11-09 07:52:33:
sqlite3BtreeGetJournalname() is a journal-mode-specific BTree-specifc function only called once, in vdbeaux.c . The purpose of this seems to be to abort if the pager says journal/WAL filenames aren't relevant. However we need to intercept this higher up, to allow for alternative backends altogether. So we should change this function call in vdbeaux.c to be sqlite3BtreeAbortCommit(), which will call sqlite3BtreeGetJournalname() in the case that standard btree is in use. danshearer added on 2026-06-20 10:10:34:
Still valid in 2026 danshearer added on 2026-06-20 10:47:54:
Actually no it isn't. We moved the level at which we modify down a bit to be less invasive, so that we now implement this function but return NULL, which is valid for the upstream. | ||||